Bug 1622654 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Filling as a good first bug to learn workflows.

while (mCaches.size()) {
should use .empty() instead

https://searchfox.org/mozilla-central/source/dom/canvas/CacheInvalidator.cpp#13

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-container-size-empty.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
Filling as a good first bug to learn workflows.

```while (mCaches.size()) {```
should use .empty() instead

https://searchfox.org/mozilla-central/source/dom/canvas/CacheInvalidator.cpp#13

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-container-size-empty.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Back to Bug 1622654 Comment 0